std::function for GLUI callbacks #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djwebb
reviewed
Nov 22, 2018
There was a problem hiding this comment.
For a c++ idiot like me, could you explain how the callbacks work here - for example at lines 243 and 244 of the original code how does "& {printf etc." link to the callback routine.
Also won't these changes require a reqrite of the manual?
David.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces GLUI_CB and the associated IDs and pointers with simply
std::function<void(void)>. This allows for using C++ lambdas for GLUI callbacks, includingstd::bind.For example:
new GLUI_Button( glui, "Quit", []() { printf("Exit\n"); exit(0); } );